From 577824b86e21b81426e0181d63ca55eeaaaa62e7 Mon Sep 17 00:00:00 2001 From: Tule Simon <58936865+TuleSimon@users.noreply.github.com> Date: Sun, 16 Apr 2023 19:09:12 +0100 Subject: [PATCH] finishedimproving naming conventiong --- app/build.gradle | 33 ++++++++++++--------------- gradle/libs.versions.toml | 48 +++++++++++++++++++-------------------- 2 files changed, 38 insertions(+), 43 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index 24e6d80a4..19d029d86 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -112,7 +112,7 @@ dependencies { implementation libs.androidx.mediarouter //Cast Dependencies - normalImplementation libs.play.services.cast.framework + //normalImplementation libs.google.play.services.cast.framework //WebServer by NanoHttpd normalImplementation libs.nanohttpd @@ -130,30 +130,25 @@ dependencies { implementation libs.androidx.core.splashscreen - normalImplementation libs.feature.delivery - normalImplementation libs.review + normalImplementation libs.google.feature.delivery + normalImplementation libs.google.play.review implementation libs.android.material - def retrofit_version = '2.9.0' implementation libs.retrofit - implementation libs.converter.gson - implementation libs.logging.interceptor + implementation libs.retrofit.converter.gson + implementation libs.okhttp3.logging.interceptor - def material_dialog_version = "3.3.0" - implementation libs.core - implementation libs.input - implementation libs.color - - implementation libs.material.cab + implementation libs.afollestad.material.dialogs.core + implementation libs.afollestad.material.dialogs.input + implementation libs.afollestad.material.dialogs.color + implementation libs.afollestad.material.cab implementation libs.kotlinx.coroutines.android - def koin_version = '3.4.0' - implementation "io.insert-koin:koin-core:$koin_version" + implementation libs.koin.core implementation libs.koin.android - def glide_version = '4.15.1' implementation libs.glide ksp libs.glide.ksp implementation libs.glide.okhttp3.integration @@ -163,17 +158,17 @@ dependencies { implementation libs.fadingedgelayout implementation libs.keyboardvisibilityevent - implementation libs.android.snowfall + implementation libs.jetradarmobile.android.snowfall - implementation libs.insetter + implementation libs.chrisbanes.insetter implementation libs.org.eclipse.egit.github.core implementation libs.jaudiotagger normalImplementation libs.android.lab.library implementation libs.slidableactivity implementation libs.material.intro - implementation libs.imagepicker + implementation libs.dhaval2404.imagepicker implementation libs.fastscroll.library implementation libs.customactivityoncrash - implementation libs.circularSeekBar + implementation libs.tankery.circularSeekBar } \ No newline at end of file diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml index 8f4732dc6..7df282da0 100644 --- a/gradle/libs.versions.toml +++ b/gradle/libs.versions.toml @@ -1,19 +1,19 @@ [versions] #buildscripts dependencies advrecyclerview = "1.0.0" -androidSnowfall = "1.2.1" -circularSeekBar = "1.4.2" -converterGson = "2.9.0" +jetradarmobile_androidSnowfall_version = "1.2.1" +tankery_circularSeekBar_version = "1.4.2" +retrofit_version = "2.9.0" afollestad_dialog_version = "3.3.0" coreSplashscreen = "1.0.0" customactivityoncrash = "2.4.0" fadingedgelayout = "1.0.0" -featureDelivery = "2.0.1" +google_featureDelivery_version = "2.0.1" gradle = "7.4.2" -imagepicker = "2.1" -insetter = "0.6.1" +dhaval2404_imagepicker_version = "2.1" +chrisbanes_insetter_version = "0.6.1" jaudiotagger = "2.3.15" -keyboardvisibilityevent = "3.0.0-RC3" +yslibrary_keyboardvisibilityevent_version = "3.0.0-RC3" koinAndroid = "3.4.0" kotlinGradlePlugin = "1.8.10" @@ -21,8 +21,8 @@ kotlinxCoroutinesAndroid = "1.6.4" android_tab_library_version = "2.0.3" fast_scroll_libraryVersion = "1.2.0" lifecycle_version = "2.6.1" -loggingInterceptor = "5.0.0-alpha.9" -materialCab = "2.0.1" +okhttp3_loggingInterceptor_version = "5.0.0-alpha.9" +afollestad_materialCab_version = "2.0.1" materialIntro = "2.0.0" mediarouter = "1.3.1" nanohttpd = "2.3.1" @@ -33,7 +33,7 @@ orgEclipseEgitGithubCore = "2.1.5" playServicesCastFramework = "21.3.0" preference_version = "1.2.0" appcompat_version = "1.6.1" -review = "2.0.1" +google_play_review_version = "2.0.1" room_version = "2.5.1" core_version = "1.10.0-rc01" @@ -61,9 +61,9 @@ androidx-room-runtime = { module = "androidx.room:room-runtime", version.ref = " androidx-room-compiler = { module = "androidx.room:room-compiler", version.ref = "room_version" } #google_play -feature-delivery = { module = "com.google.android.play:feature-delivery", version.ref = "featureDelivery" } +google-feature-delivery = { module = "com.google.android.play:feature-delivery", version.ref = "google_featureDelivery_version" } play-services-cast-framework = { module = "com.google.android.gms:play-services-cast-framework", version.ref = "playServicesCastFramework" } -review = { module = "com.google.android.play:review", version.ref = "review" } +google-play-review = { module = "com.google.android.play:review", version.ref = "google_play_review_version" } #glide glide = { module = "com.github.bumptech.glide:glide", version.ref = "glide_version" } @@ -77,15 +77,15 @@ koin-core = { module = "io.insert-koin:koin-core", version.ref = "koinAndroid" } #material dialog -afollestad-material-dialogs-color = { module = "com.afollestad.material-dialogs:color", version.ref = "core" } -afollestad-material-dialogs-core = { module = "com.afollestad.material-dialogs:core", version.ref = "core" } -input = { module = "com.afollestad.material-dialogs:input", version.ref = "core" } -material-cab = { module = "com.afollestad:material-cab", version.ref = "materialCab" } +afollestad-material-dialogs-color = { module = "com.afollestad.material-dialogs:color", version.ref = "afollestad_dialog_version" } +afollestad-material-dialogs-core = { module = "com.afollestad.material-dialogs:core", version.ref = "afollestad_dialog_version" } +afollestad-material-dialogs-input = { module = "com.afollestad.material-dialogs:input", version.ref = "afollestad_dialog_version" } +afollestad-material-cab = { module = "com.afollestad:material-cab", version.ref = "afollestad_materialCab_version" } #Retrofit and apos -converter-gson = { module = "com.squareup.retrofit2:converter-gson", version.ref = "converterGson" } -logging-interceptor = { module = "com.squareup.okhttp3:logging-interceptor", version.ref = "loggingInterceptor" } -retrofit = { module = "com.squareup.retrofit2:retrofit", version.ref = "converterGson" } +retrofit-converter-gson = { module = "com.squareup.retrofit2:converter-gson", version.ref = "retrofit_version" } +okhttp3-logging-interceptor = { module = "com.squareup.okhttp3:logging-interceptor", version.ref = "okhttp3_loggingInterceptor_version" } +retrofit = { module = "com.squareup.retrofit2:retrofit", version.ref = "retrofit_version" } #misc gridLayout = { group = "androidx.gridlayout", name = "gridlayout", version = "1.0.0" } @@ -93,18 +93,18 @@ android-material = { module = "com.google.android.material:material", version.re kotlinx-coroutines-android = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-android", version.ref = "kotlinxCoroutinesAndroid" } advrecyclerview = { module = "com.h6ah4i.android.widget.advrecyclerview:advrecyclerview", version.ref = "advrecyclerview" } fadingedgelayout = { module = "com.github.bosphere.android-fadingedgelayout:fadingedgelayout", version.ref = "fadingedgelayout" } -keyboardvisibilityevent = { module = "net.yslibrary.keyboardvisibilityevent:keyboardvisibilityevent", version.ref = "keyboardvisibilityevent" } -android-snowfall = { module = "com.github.jetradarmobile:android-snowfall", version.ref = "androidSnowfall" } -insetter = { module = "dev.chrisbanes.insetter:insetter", version.ref = "insetter" } +keyboardvisibilityevent = { module = "net.yslibrary.keyboardvisibilityevent:keyboardvisibilityevent", version.ref = "yslibrary_keyboardvisibilityevent_version" } +jetradarmobile-android-snowfall = { module = "com.github.jetradarmobile:android-snowfall", version.ref = "jetradarmobile_androidSnowfall_version" } +chrisbanes-insetter = { module = "dev.chrisbanes.insetter:insetter", version.ref = "chrisbanes_insetter_version" } org-eclipse-egit-github-core = { module = "org.eclipse.mylyn.github:org.eclipse.egit.github.core", version.ref = "orgEclipseEgitGithubCore" } jaudiotagger = { module = "com.github.Adonai:jaudiotagger", version.ref = "jaudiotagger" } android-lab-library = { module = "com.anjlab.android.iab.v3:library", version.ref = "android_tab_library_version" } slidableactivity = { module = "com.r0adkll:slidableactivity", version.ref = "slidableactivity" } material-intro = { module = "com.heinrichreimersoftware:material-intro", version.ref = "materialIntro" } -imagepicker = { module = "com.github.dhaval2404:imagepicker", version.ref = "imagepicker" } +dhaval2404-imagepicker = { module = "com.github.dhaval2404:imagepicker", version.ref = "dhaval2404_imagepicker_version" } fastscroll-library = { module = "me.zhanghai.android.fastscroll:library", version.ref = "fast_scroll_libraryVersion" } customactivityoncrash = { module = "cat.ereza:customactivityoncrash", version.ref = "customactivityoncrash" } -circularSeekBar = { module = "me.tankery.lib:circularSeekBar", version.ref = "circularSeekBar" } +tankery-circularSeekBar = { module = "me.tankery.lib:circularSeekBar", version.ref = "tankery_circularSeekBar_version" } androidx-mediarouter = { group = "androidx.mediarouter", name="mediarouter", version.ref = "mediarouter" } nanohttpd = { group = "org.nanohttpd", name="nanohttpd", version.ref = "nanohttpd" }