Cleanup with Kotlin extension functions

app/src/main/java/code/name/monkey/retromusic/activities/PurchaseActivity.kt

@@ -19,8 +19,6 @@ import android.graphics.Color
 import android.os.Bundle
 import android.util.Log
 import android.view.MenuItem
-import android.widget.Toast
-import code.name.monkey.appthemehelper.ThemeStore
 import code.name.monkey.appthemehelper.util.MaterialUtil
 import code.name.monkey.retromusic.App
 import code.name.monkey.retromusic.BuildConfig
@@ -31,6 +29,7 @@ import code.name.monkey.retromusic.databinding.ActivityProVersionBinding
 import code.name.monkey.retromusic.extensions.accentColor
 import code.name.monkey.retromusic.extensions.setLightStatusBar
 import code.name.monkey.retromusic.extensions.setStatusBarColor
+import code.name.monkey.retromusic.extensions.showToast
 import com.anjlab.android.iab.v3.BillingProcessor
 import com.anjlab.android.iab.v3.PurchaseInfo
 
@@ -66,8 +65,7 @@ class PurchaseActivity : AbsBaseActivity(), BillingProcessor.IBillingHandler {
     }
 
     private fun restorePurchase() {
-        Toast.makeText(this, R.string.restoring_purchase, Toast.LENGTH_SHORT)
-            .show()
+        showToast(R.string.restoring_purchase)
         billingProcessor.loadOwnedPurchasesFromGoogleAsync(object :
             BillingProcessor.IPurchasesResponseListener {
             override fun onPurchasesSuccess() {
@@ -75,30 +73,22 @@ class PurchaseActivity : AbsBaseActivity(), BillingProcessor.IBillingHandler {
             }
 
             override fun onPurchasesError() {
-                Toast.makeText(
-                    this@PurchaseActivity,
-                    R.string.could_not_restore_purchase,
-                    Toast.LENGTH_SHORT
-                ).show()
+                showToast(R.string.could_not_restore_purchase)
             }
         })
     }
 
     override fun onProductPurchased(productId: String, details: PurchaseInfo?) {
-        Toast.makeText(this, R.string.thank_you, Toast.LENGTH_SHORT).show()
+        showToast(R.string.thank_you)
         setResult(RESULT_OK)
     }
 
     override fun onPurchaseHistoryRestored() {
         if (App.isProVersion()) {
-            Toast.makeText(
-                this,
-                R.string.restored_previous_purchase_please_restart,
-                Toast.LENGTH_LONG
-            ).show()
+            showToast(R.string.restored_previous_purchase_please_restart)
             setResult(RESULT_OK)
         } else {
-            Toast.makeText(this, R.string.no_purchase_found, Toast.LENGTH_SHORT).show()
+            showToast(R.string.no_purchase_found)
         }
     }
 

app/src/main/java/code/name/monkey/retromusic/activities/SupportDevelopmentActivity.kt

@@ -21,12 +21,10 @@ import android.view.LayoutInflater
 import android.view.MenuItem
 import android.view.ViewGroup
 import android.widget.TextView
-import android.widget.Toast
 import androidx.core.view.isVisible
 import androidx.recyclerview.widget.DefaultItemAnimator
 import androidx.recyclerview.widget.GridLayoutManager
 import androidx.recyclerview.widget.RecyclerView
-import code.name.monkey.appthemehelper.ThemeStore
 import code.name.monkey.appthemehelper.util.ATHUtil
 import code.name.monkey.appthemehelper.util.TintHelper
 import code.name.monkey.appthemehelper.util.ToolbarContentTintHelper
@@ -121,7 +119,7 @@ class SupportDevelopmentActivity : AbsBaseActivity(), BillingProcessor.IBillingH
 
     override fun onProductPurchased(productId: String, details: PurchaseInfo?) {
         // loadSkuDetails();
-        Toast.makeText(this, R.string.thank_you, Toast.LENGTH_SHORT).show()
+        showToast(R.string.thank_you)
     }
 
     override fun onBillingError(errorCode: Int, error: Throwable?) {
@@ -130,7 +128,7 @@ class SupportDevelopmentActivity : AbsBaseActivity(), BillingProcessor.IBillingH
 
     override fun onPurchaseHistoryRestored() {
         // loadSkuDetails();
-        Toast.makeText(this, R.string.restored_previous_purchases, Toast.LENGTH_SHORT).show()
+        showToast(R.string.restored_previous_purchases)
     }
 
     override fun onDestroy() {

app/src/main/java/code/name/monkey/retromusic/activities/bugreport/BugReportActivity.kt

@@ -20,7 +20,6 @@ import android.content.Intent
 import android.os.Bundle
 import android.view.MenuItem
 import android.view.inputmethod.EditorInfo
-import android.widget.Toast
 import androidx.annotation.StringDef
 import androidx.annotation.StringRes
 import androidx.core.content.getSystemService
@@ -39,6 +38,7 @@ import code.name.monkey.retromusic.activities.bugreport.model.github.GithubTarge
 import code.name.monkey.retromusic.databinding.ActivityBugReportBinding
 import code.name.monkey.retromusic.extensions.accentColor
 import code.name.monkey.retromusic.extensions.setTaskDescriptionColorAuto
+import code.name.monkey.retromusic.extensions.showToast
 import com.google.android.material.dialog.MaterialAlertDialogBuilder
 import com.google.android.material.floatingactionbutton.FloatingActionButton
 import com.google.android.material.textfield.TextInputLayout
@@ -163,11 +163,7 @@ open class BugReportActivity : AbsThemeActivity() {
         val clipboard = getSystemService<ClipboardManager>()
         val clip = ClipData.newPlainText(getString(R.string.device_info), deviceInfo?.toMarkdown())
         clipboard?.setPrimaryClip(clip)
-        Toast.makeText(
-            this@BugReportActivity,
-            R.string.copied_device_info_to_clipboard,
-            Toast.LENGTH_LONG
-        ).show()
+        showToast(R.string.copied_device_info_to_clipboard)
     }
 
     private fun validateInput(): Boolean {

app/src/main/java/code/name/monkey/retromusic/activities/tageditor/AlbumTagEditorActivity.kt

@@ -30,10 +30,7 @@ import androidx.core.widget.doAfterTextChanged
 import code.name.monkey.appthemehelper.util.MaterialValueHelper
 import code.name.monkey.retromusic.R
 import code.name.monkey.retromusic.databinding.ActivityAlbumTagEditorBinding
-import code.name.monkey.retromusic.extensions.appHandleColor
-import code.name.monkey.retromusic.extensions.defaultFooterColor
-import code.name.monkey.retromusic.extensions.isColorLight
-import code.name.monkey.retromusic.extensions.setTint
+import code.name.monkey.retromusic.extensions.*
 import code.name.monkey.retromusic.glide.GlideApp
 import code.name.monkey.retromusic.glide.palette.BitmapPaletteWrapper
 import code.name.monkey.retromusic.model.ArtworkInfo
@@ -117,11 +114,7 @@ class AlbumTagEditorActivity : AbsTagEditorActivity<ActivityAlbumTagEditorBindin
     }
 
     private fun toastLoadingFailed() {
-        Toast.makeText(
-            this@AlbumTagEditorActivity,
-            R.string.could_not_download_album_cover,
-            Toast.LENGTH_SHORT
-        ).show()
+        showToast(R.string.could_not_download_album_cover)
     }
 
     override fun searchImageOnWeb() {
@@ -161,8 +154,7 @@ class AlbumTagEditorActivity : AbsTagEditorActivity<ActivityAlbumTagEditorBindin
 
                 override fun onLoadFailed(errorDrawable: Drawable?) {
                     super.onLoadFailed(errorDrawable)
-                    Toast.makeText(this@AlbumTagEditorActivity, "Load Failed", Toast.LENGTH_LONG)
-                        .show()
+                    showToast("Load Failed", Toast.LENGTH_LONG)
                 }
 
                 override fun setResource(resource: BitmapPaletteWrapper?) {}

app/src/main/java/code/name/monkey/retromusic/activities/tageditor/SongTagEditorActivity.kt

@@ -30,10 +30,7 @@ import androidx.core.widget.doAfterTextChanged
 import code.name.monkey.appthemehelper.util.MaterialValueHelper
 import code.name.monkey.retromusic.R
 import code.name.monkey.retromusic.databinding.ActivitySongTagEditorBinding
-import code.name.monkey.retromusic.extensions.appHandleColor
-import code.name.monkey.retromusic.extensions.defaultFooterColor
-import code.name.monkey.retromusic.extensions.isColorLight
-import code.name.monkey.retromusic.extensions.setTint
+import code.name.monkey.retromusic.extensions.*
 import code.name.monkey.retromusic.glide.GlideApp
 import code.name.monkey.retromusic.glide.palette.BitmapPaletteWrapper
 import code.name.monkey.retromusic.model.ArtworkInfo
@@ -196,8 +193,7 @@ class SongTagEditorActivity : AbsTagEditorActivity<ActivitySongTagEditorBinding>
 
                 override fun onLoadFailed(errorDrawable: Drawable?) {
                     super.onLoadFailed(errorDrawable)
-                    Toast.makeText(this@SongTagEditorActivity, "Load Failed", Toast.LENGTH_LONG)
-                        .show()
+                    showToast("Load Failed", Toast.LENGTH_LONG)
                 }
 
                 override fun setResource(resource: BitmapPaletteWrapper?) {}

app/src/main/java/code/name/monkey/retromusic/activities/tageditor/TagWriter.kt

@@ -6,8 +6,8 @@ import android.graphics.Bitmap
 import android.media.MediaScannerConnection
 import android.os.Build
 import android.util.Log
-import android.widget.Toast
 import androidx.annotation.RequiresApi
+import code.name.monkey.retromusic.extensions.showToast
 import code.name.monkey.retromusic.misc.UpdateToastMediaScannerCompletionListener
 import code.name.monkey.retromusic.model.AudioTagInfo
 import code.name.monkey.retromusic.util.MusicUtil.createAlbumArtFile
@@ -24,7 +24,6 @@ import org.jaudiotagger.tag.TagException
 import org.jaudiotagger.tag.images.AndroidArtwork
 import org.jaudiotagger.tag.images.Artwork
 import java.io.File
-import java.io.FileOutputStream
 import java.io.IOException
 
 class TagWriter {
@@ -34,7 +33,7 @@ class TagWriter {
         suspend fun scan(context: Context, toBeScanned: List<String?>?) {
             if (toBeScanned == null || toBeScanned.isEmpty()) {
                 Log.i("scan", "scan: Empty")
-                Toast.makeText(context, "Scan file from folder", Toast.LENGTH_SHORT).show()
+                context.showToast( "Scan file from folder")
                 return
             }
             MediaScannerConnection.scanFile(
@@ -60,7 +59,7 @@ class TagWriter {
                             info.artworkInfo.artwork.compress(
                                 Bitmap.CompressFormat.JPEG,
                                 100,
-                                FileOutputStream(albumArtFile)
+                                albumArtFile.outputStream()
                             )
                             artwork = AndroidArtwork.createArtworkFromFile(albumArtFile)
                         } catch (e: IOException) {
@@ -133,7 +132,7 @@ class TagWriter {
                             info.artworkInfo.artwork.compress(
                                 Bitmap.CompressFormat.JPEG,
                                 100,
-                                FileOutputStream(albumArtFile)
+                                albumArtFile.outputStream()
                             )
                             artwork = AndroidArtwork.createArtworkFromFile(albumArtFile)
                         } catch (e: IOException) {