cmclark00/retro-imager
1
0
Fork 0
mirror of https://github.com/cmclark00/retro-imager.git synced 2025-05-18 16:05:21 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix clazy-range-loop-detachs and other clazy complaints

Browse source
This commit is contained in:
Floris Bos 2022-07-26 23:13:52 +02:00
parent 8837d7e897
commit 152831e72f
5 changed files with 11 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/linux/udisks2api.cpp
View file

@ -56,7 +56,7 @@ QString UDisks2Api::_resolveDevice(const QString &device)
if (!manager.isValid() || !list.isValid() || list.value().isEmpty())
return QString();
return list.value().first().path();
return list.value().constFirst().path();
}
void UDisks2Api::_unmountDrive(const QString &driveDbusPath)
@ -66,12 +66,13 @@ void UDisks2Api::_unmountDrive(const QString &driveDbusPath)
QDBusInterface manager("org.freedesktop.UDisks2", "/org/freedesktop/UDisks2/Manager",
"org.freedesktop.UDisks2.Manager", QDBusConnection::systemBus());
QVariantMap options;
QDBusReply<QList<QDBusObjectPath>> list = manager.call("GetBlockDevices", options);
const QDBusReply<QList<QDBusObjectPath>> list = manager.call("GetBlockDevices", options);
if (!manager.isValid() || !list.isValid())
return;
for (const auto& devpath : list.value())
const auto listValue = list.value();
for (const auto& devpath : listValue)
{
QString devpathStr = devpath.path();
@ -263,7 +264,8 @@ QByteArrayList UDisks2Api::mountPoints(const QDBusInterface &filesystem)
QVariantList args = {"org.freedesktop.UDisks2.Filesystem", "MountPoints"};
msg.setArguments(args);
QDBusMessage reply = QDBusConnection::systemBus().call(msg);
for (const auto& arg : reply.arguments())
const auto replyArgs = reply.arguments();
for (const auto& arg : replyArgs)
{
arg.value<QDBusVariant>().variant().value<QDBusArgument>() >> mps;
}