cmclark00/retro-imager
1
0
Fork 0
mirror of https://github.com/cmclark00/retro-imager.git synced 2025-05-18 16:05:21 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #450 from marcelpetrick/mpe/clazy

Browse source 
code-quality: fixed all range-loop warnings which were reported from clazy
This commit is contained in:
maxnet 2022-07-26 22:26:07 +02:00 • committed by GitHub
commit 280469c50f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/dependencies/mountutils/src/linux/functions.cpp
View file

@ -97,7 +97,7 @@ MOUNTUTILS_RESULT unmount_disk(const char *device_path) {
size_t unmounts = 0;
MOUNTUTILS_RESULT result_code = MOUNTUTILS_SUCCESS;
for (std::string mount_dir : mount_dirs) {
for (const std::string& mount_dir : mount_dirs) {
MountUtilsLog("Unmounting " + mount_dir + "...");
mount_path = mount_dir.c_str();

4
src/downloadextractthread.cpp
View file

@ -231,7 +231,7 @@ void DownloadExtractThread::extractMultiFileRun()
{
QThread::sleep(1);
auto l = Drivelist::ListStorageDevices();
for (auto i : l)
for (const auto& i : l)
{
if (QByteArray::fromStdString(i.device).toLower() == devlower && i.mountpoints.size() == 1)
{
@ -363,7 +363,7 @@ void DownloadExtractThread::extractMultiFileRun()
_cachefile.remove();
qDebug() << "Deleting extracted files";
for (auto filename : filesExtracted)
for (const auto& filename : filesExtracted)
{
QFileInfo fi(filename);
QString path = fi.path();

10
src/downloadthread.cpp
View file

@ -871,7 +871,7 @@ bool DownloadThread::_customizeImage()
{
QThread::sleep(1);
auto l = Drivelist::ListStorageDevices();
for (auto i : l)
for (const auto& i : l)
{
if (QByteArray::fromStdString(i.device).toLower() == devlower && i.mountpoints.size())
{
@ -951,10 +951,10 @@ bool DownloadThread::_customizeImage()
//
qDebug() << "drive info. searching for:" << devlower;
auto l = Drivelist::ListStorageDevices();
for (auto i : l)
for (const auto& i : l)
{
qDebug() << "drive" << QByteArray::fromStdString(i.device).toLower();
for (auto mp : i.mountpoints) {
for (const auto& mp : i.mountpoints) {
qDebug() << "mountpoint:" << QByteArray::fromStdString(mp);
}
}
@ -973,7 +973,7 @@ bool DownloadThread::_customizeImage()
{
/* Search all mountpoints, as on some systems FAT partition
may not be first volume */
for (auto mp : mountpoints)
for (const auto& mp : mountpoints)
{
folder = QString::fromStdString(mp);
if (folder.right(1) == '\\')
@ -1012,7 +1012,7 @@ bool DownloadThread::_customizeImage()
f.close();
}
for (QByteArray item : configItems)
for (const QByteArray& item : configItems)
{
if (config.contains("#"+item)) {
/* Uncomment existing line */

2
src/linux/linuxdrivelist.cpp
View file

@ -132,7 +132,7 @@ namespace Drivelist
if (d.isSystem && subsystems.contains("nvme"))
{
bool isMounted = false;
for (std::string mp : d.mountpoints)
for (const std::string& mp : d.mountpoints)
{
if (!QByteArray::fromStdString(mp).startsWith("/media/")) {
isMounted = true;

4
src/linux/udisks2api.cpp
View file

@ -71,7 +71,7 @@ void UDisks2Api::_unmountDrive(const QString &driveDbusPath)
if (!manager.isValid() || !list.isValid())
return;
for (auto devpath : list.value())
for (const auto& devpath : list.value())
{
QString devpathStr = devpath.path();
@ -263,7 +263,7 @@ QByteArrayList UDisks2Api::mountPoints(const QDBusInterface &filesystem)
QVariantList args = {"org.freedesktop.UDisks2.Filesystem", "MountPoints"};
msg.setArguments(args);
QDBusMessage reply = QDBusConnection::systemBus().call(msg);
for (auto arg : reply.arguments())
for (const auto& arg : reply.arguments())
{
arg.value<QDBusVariant>().variant().value<QDBusArgument>() >> mps;
}