cmclark00/retro-imager
1
0
Fork 0
mirror of https://github.com/cmclark00/retro-imager.git synced 2025-05-18 16:05:21 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Linux/OSX: Fix reversed fsync check

Browse source 
This if() condition checks the result of seek, write, flush
and fsync. The first three are methods on QFile, so return
a truthy value on success. write() returns number of bytes
written while seek() and flush() return bool true on success.
Therefore they have to be inverted to detect errors. However,
fsync() is a posix system call, so it returns zero (false) on
success. Therefore it should not be inverted.

Note that currently this entire code block can never run.
knownsize is always zero because QFile.size() currently
cannot determine the size of a block device. However, when I
asked to confirm this behavior, a Qt maintainer decided to
implement it, so there is now a PR. If that is released then
this code block will become live and the reversed fsync check
will cause a problem.

PR: https://codereview.qt-project.org/c/qt/qtbase/+/581443
This commit is contained in:
Alistair Buxton 2024-08-07 10:52:45 +01:00 • committed by Tom Dewey
parent c1c8c5a7dd
commit 7725ce7a40
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/downloadthread.cpp
View file

@ -314,7 +314,7 @@ bool DownloadThread::_openAndPrepareDevice()
if (!_file.seek(knownsize-emptyMB.size()) if (!_file.seek(knownsize-emptyMB.size())
|| !_file.write(emptyMB.data(), emptyMB.size()) || !_file.write(emptyMB.data(), emptyMB.size())
|| !_file.flush() || !_file.flush()
|| !::fsync(_file.handle())) || ::fsync(_file.handle()))
{ {
emit error(tr("Write error while trying to zero out last part of card.<br>" emit error(tr("Write error while trying to zero out last part of card.<br>"
"Card could be advertising wrong capacity (possible counterfeit).")); "Card could be advertising wrong capacity (possible counterfeit)."));