cmclark00/retro-imager
1
0
Fork 0
mirror of https://github.com/cmclark00/retro-imager.git synced 2025-05-18 16:05:21 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

code-quality: fixed all range-loop warnings which were reported from clazy.

Browse source 
See: `rpi-imager/src/downloadthread.cpp:1015:14: warning: Missing reference in range-for with non trivial type (QByteArray) [clazy-range-loop]`
This commit is contained in:
Marcel Petrick 2022-06-08 17:54:06 +02:00
parent 8d943ce2bd
commit 829c200fd1
5 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/downloadthread.cpp
View file

@ -871,7 +871,7 @@ bool DownloadThread::_customizeImage()
{
QThread::sleep(1);
auto l = Drivelist::ListStorageDevices();
for (auto i : l)
for (const auto& i : l)
{
if (QByteArray::fromStdString(i.device).toLower() == devlower && i.mountpoints.size())
{
@ -951,10 +951,10 @@ bool DownloadThread::_customizeImage()
//
qDebug() << "drive info. searching for:" << devlower;
auto l = Drivelist::ListStorageDevices();
for (auto i : l)
for (const auto& i : l)
{
qDebug() << "drive" << QByteArray::fromStdString(i.device).toLower();
for (auto mp : i.mountpoints) {
for (const auto& mp : i.mountpoints) {
qDebug() << "mountpoint:" << QByteArray::fromStdString(mp);
}
}
@ -973,7 +973,7 @@ bool DownloadThread::_customizeImage()
{
/* Search all mountpoints, as on some systems FAT partition
may not be first volume */
for (auto mp : mountpoints)
for (const auto& mp : mountpoints)
{
folder = QString::fromStdString(mp);
if (folder.right(1) == '\\')
@ -1012,7 +1012,7 @@ bool DownloadThread::_customizeImage()
f.close();
}
for (QByteArray item : configItems)
for (const QByteArray& item : configItems)
{
if (config.contains("#"+item)) {
/* Uncomment existing line */