cmclark00/retro-imager
1
0
Fork 0
mirror of https://github.com/cmclark00/retro-imager.git synced 2025-05-19 00:15:21 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

code-quality: fixed all range-loop warnings which were reported from clazy.

Browse source 
See: `rpi-imager/src/downloadthread.cpp:1015:14: warning: Missing reference in range-for with non trivial type (QByteArray) [clazy-range-loop]`
This commit is contained in:
Marcel Petrick 2022-06-08 17:54:06 +02:00
parent 8d943ce2bd
commit 829c200fd1
5 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/linux/linuxdrivelist.cpp
View file

@ -132,7 +132,7 @@ namespace Drivelist
if (d.isSystem && subsystems.contains("nvme"))
{
bool isMounted = false;
for (std::string mp : d.mountpoints)
for (const std::string& mp : d.mountpoints)
{
if (!QByteArray::fromStdString(mp).startsWith("/media/")) {
isMounted = true;

4
src/linux/udisks2api.cpp
View file

@ -71,7 +71,7 @@ void UDisks2Api::_unmountDrive(const QString &driveDbusPath)
if (!manager.isValid() || !list.isValid())
return;
for (auto devpath : list.value())
for (const auto& devpath : list.value())
{
QString devpathStr = devpath.path();
@ -263,7 +263,7 @@ QByteArrayList UDisks2Api::mountPoints(const QDBusInterface &filesystem)
QVariantList args = {"org.freedesktop.UDisks2.Filesystem", "MountPoints"};
msg.setArguments(args);
QDBusMessage reply = QDBusConnection::systemBus().call(msg);
for (auto arg : reply.arguments())
for (const auto& arg : reply.arguments())
{
arg.value<QDBusVariant>().variant().value<QDBusArgument>() >> mps;
}