This if() condition checks the result of seek, write, flush
and fsync. The first three are methods on QFile, so return
a truthy value on success. write() returns number of bytes
written while seek() and flush() return bool true on success.
Therefore they have to be inverted to detect errors. However,
fsync() is a posix system call, so it returns zero (false) on
success. Therefore it should not be inverted.
Note that currently this entire code block can never run.
knownsize is always zero because QFile.size() currently
cannot determine the size of a block device. However, when I
asked to confirm this behavior, a Qt maintainer decided to
implement it, so there is now a PR. If that is released then
this code block will become live and the reversed fsync check
will cause a problem.
PR: https://codereview.qt-project.org/c/qt/qtbase/+/581443
- No longer relies on operating system for mounting FAT partition
when applying 'advanced settings'
- change '__attribute__ ((packed))' to '#pragma pack()' as the
mingw version we are using for Windows has a bug with the former
- If a drive is formatted APFS it will have a seperate disk
devices for physical drive (e.g. /dev/disk2) and volumes
(e.g. /dev/disk3).
Need to unmount all, or opening the device for
writing will subsequently fail.
(User will see an "Error running authopen" error in Imager
in that case).
- Also do not show APFS volumes seperately in the disk
selection dialog. List mount points under physical drive
instead.
Closes#501
