Commit graph

11 commits

Author SHA1 Message Date
Tom Dewey
cf8c4bc66d qml: UseSavedSettingsPopup: Qt6 fixes
Use anchors preferentially, and nest the title bar elements
2024-09-11 17:12:48 +01:00
David Turner
8a3331f613 Improve red button focus colour
- All of our red buttons were ImButton with the colours overridden at the
  use site.  Instead make an ImButtonRed which defines these colours in
  one place.
- Previously the red buttons had focus indicated by the text colour
  changing from white to blue.  This was quite hard to see, instead
  change the button colour to blue (as is done for the white buttons).
  A darker shade of blue is used so that there is still good contrast
  with the white text.
- Update the reds (buttons and main screen background) with the
  branding-approved red: the official colour palette says Pi Red is
  #cd2355
2023-10-18 17:01:47 +01:00
David Turner
4ad4276154 Don't hide "use customization" when editing settings
Previously, if you clicked "edit settings" in the "use customisation"
msgbox then the flow got a bit confusing, when you saved settings the
"use customisation" msgbox would have disappeared and you had to click
"next" and go back through again.  Instead, keep the "use customisation"
msgbox open when editing settings so when you save settings you are back
where you left it.

Also:
- Make "use customisation" modal so you can't click other things while
  it's open
- Separate windows in QtQuick can't be modal so we can't stop the user
  interacting with the main window while "edit settings" is open.  This
  could get confusing, so if they close the "use customisation" modal in
  the main window then close the settings window.
- Fix a bug where saved settings weren't recognised on startup, only
  after being saved during the session
2023-10-18 11:33:11 +01:00
Tom Dewey tom.dewey@raspberrypi.com
ecf992cb62 Rework OS Customization
In the new flow, it doesn't make sense to _not_ save the OS
customization parameters, so remove the ComboBox.

Additionally, our data model was failing to notify the UI of changes to
the saved settings state. Due to time constraints, I'm not able to
resolve the binding in the 'correct' manner, but I can introduce a
makeshift status signalling mechanism to prevent UI inconsistency.
2023-10-17 15:28:04 +01:00
Tom Dewey tom.dewey@raspberrypi.com
50449158bc i18n: Advanced settings -> OS customization
Per a request from the Raspberry Pi Communications team, change
'Advanced Settings' and 'Image customization' to read 'OS
customization'.

This is to avoid amibuguity in the English, where Image_r_ and Image may
be conflated when reading at speed.

Regrettably, this breaks the existing translations. To prevent
confusion, explicitly delete the existing translations - as they're almost
certainly not valid with the reworded meaning.
2023-10-17 15:28:04 +01:00
Tom Dewey tom.dewey@raspberrypi.com
a5c736f230 Revert "i18n: Advanced Settings -> OS Customisation"
This reverts commit 2fb58dc01c.

The original commit included an unexpected deletion of _all_
translations in certain languages. This was unintented, and appears to
have been a merging artefact.

This change will be re-submitted as a separate PR.
2023-10-16 13:06:21 +01:00
Tom Dewey tom.dewey@raspberrypi.com
2fb58dc01c i18n: Advanced Settings -> OS Customisation 2023-10-16 11:46:54 +01:00
Tom Dewey tom.dewey@raspberrypi.com
2b2fd7de8a qml: Remove customisation button, roll into flow
This patch carries a translation risk, as we change the default
progression button.

Remove the customisation button all together, and make the customisation
options something we offer as part of flashing an image that
has that capability.

While this adds an additional click to the flash sequence, it should
provide a steer to people who are flashing customisable images to make
use of this capability, potentially avoiding an additional pass through the
Imager.
2023-10-12 12:28:19 +01:00
Floris Bos
1ab22a1d9e Size "Do you want to use saved settings?" dialog box better
Prevents buttons overflowing the dialog box when German language
translation is used.
(Issue reported on forum)
2023-05-18 15:06:29 +02:00
Floris Bos
b93fe29617 Apply advanced settings prompt: offer "no" without clear options
By request.
When prompted if previous settings should be applied, offer a
"no" button that only applies this time, and does not clear
settings.
2023-03-24 14:26:43 +01:00
Floris Bos
033ff07abf Move source files to /src 2022-02-14 10:07:15 +01:00
Renamed from UseSavedSettingsPopup.qml (Browse further)